ingester: Revert stringlabels in performance critical paths#6980
Draft
harry671003 wants to merge 1 commit intocortexproject:masterfrom
Draft
ingester: Revert stringlabels in performance critical paths#6980harry671003 wants to merge 1 commit intocortexproject:masterfrom
harry671003 wants to merge 1 commit intocortexproject:masterfrom
Conversation
friedrichg
changed the title
yeya24
reviewed
Aug 29, 2025
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Do we plan to continue this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
After deploying Cortex with the latest Prometheus update #6930, we saw an increase in 5XXs from distributor -> ingesters.
This PR reverts the suspicious change from the PR.
cortexpb.FromLabelAdaptersToLabelsWithCopy()is used in Push() when a new series is created.cortex/pkg/ingester/ingester.go
Line 1349 in a776fe4
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]